Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Toggle flow online or offline #3183

Merged
merged 3 commits into from
May 28, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented May 21, 2024

What does this PR do?

  • Adds a menu option (in /:team/:flow/settings/service) to allow Editors to toggle a flow online/offline

Questions

This page now has a mix-match of form styles which is not ideal, I've opted for the most recent styles used in the themes page. This is easily fixed in future - @ianjon3s is taking a look at styles across some of these pages currently. Is it acceptable to live with this inconsistency in the short term?

I've not added any visual indication of a flow's status (e.g. an icon or style) - should we try to communicate this, and how?

Next steps

image

Copy link

github-actions bot commented May 21, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/flow-offline-online branch 3 times, most recently from 8a462a6 to 88939f6 Compare May 24, 2024 07:55
Base automatically changed from dp/flow-offline-online to main May 24, 2024 08:20
@DafyddLlyr DafyddLlyr force-pushed the dp/frontend-toggle-offline branch 2 times, most recently from 96535f2 to 40b3f1e Compare May 24, 2024 08:25
@theopensystemslab theopensystemslab deleted a comment from github-actions bot May 24, 2024
@DafyddLlyr DafyddLlyr force-pushed the dp/frontend-toggle-offline branch from 40b3f1e to c27ad55 Compare May 24, 2024 12:39
@DafyddLlyr DafyddLlyr force-pushed the dp/frontend-toggle-offline branch from c27ad55 to b2356a0 Compare May 24, 2024 15:33
@DafyddLlyr DafyddLlyr requested a review from a team May 24, 2024 16:27
@DafyddLlyr DafyddLlyr marked this pull request as ready for review May 24, 2024 16:27
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great as a solution using current form styles. I'll be standardising the form styles imminently so will factor this in. I'll also think about how we can show the online/offline status on the 'select a service' screen.

@DafyddLlyr DafyddLlyr merged commit 3c048ff into main May 28, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/frontend-toggle-offline branch May 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants