-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Toggle flow online or offline #3183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/flow-offline-online
branch
3 times, most recently
from
May 24, 2024 07:55
8a462a6
to
88939f6
Compare
DafyddLlyr
force-pushed
the
dp/frontend-toggle-offline
branch
2 times, most recently
from
May 24, 2024 08:25
96535f2
to
40b3f1e
Compare
DafyddLlyr
force-pushed
the
dp/frontend-toggle-offline
branch
from
May 24, 2024 12:39
40b3f1e
to
c27ad55
Compare
DafyddLlyr
force-pushed
the
dp/frontend-toggle-offline
branch
from
May 24, 2024 15:33
c27ad55
to
b2356a0
Compare
ianjon3s
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great as a solution using current form styles. I'll be standardising the form styles imminently so will factor this in. I'll also think about how we can show the online/offline status on the 'select a service' screen.
jessicamcinchak
approved these changes
May 28, 2024
editor.planx.uk/src/pages/FlowEditor/components/Settings/ServiceSettings.tsx
Show resolved
Hide resolved
editor.planx.uk/src/pages/FlowEditor/components/Settings/ServiceSettings.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/:team/:flow/settings/service
) to allow Editors to toggle a flow online/offlineQuestions
This page now has a mix-match of form styles which is not ideal, I've opted for the most recent styles used in the themes page. This is easily fixed in future - @ianjon3s is taking a look at styles across some of these pages currently. Is it acceptable to live with this inconsistency in the short term?
I've not added any visual indication of a flow's status (e.g. an icon or style) - should we try to communicate this, and how?
Next steps